Enable programmatic submission via Frames ref (submitCard); update docs, tests, and dependencies #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bump `expo` and `babel-preset-expo` versions in `package.json` and `package-lock.json`. - Upgrade `jest-expo` to match the new `expo` version. - Refactor integration tests for `Frames` component to mock network requests and improve validation checks. - Remove redundant tests and ensure proper error handling for card tokenization. - Add new tests for billing details and card validation events.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
===========================================
- Coverage 94.14% 68.83% -25.31%
===========================================
Files 12 12
Lines 205 215 +10
Branches 57 62 +5
===========================================
- Hits 193 148 -45
- Misses 2 37 +35
- Partials 10 30 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Simplified state initialization in the Frames component by defining initialState separately. - Updated TypeScript types to allow null values for card-related fields in FramesState. - Changed autoCompleteType to autoComplete in CardNumber, Cvv, and ExpiryDate components for better compatibility. - Ensured safe access to state properties by using nullish coalescing in input values. - Refactored framesReducer to use a more explicit action parameter for better type safety.
- Updated the Frames component to support programmatic card submission via a ref using `submitCard()`. - Modified README to include new usage example for programmatic submission. - Adjusted integration tests to validate the new submission method and ensure proper tokenization. - Updated public key in tests and other files for consistency.
ioan-ghisoi-cko
changed the title
- Bumped package version from 1.2.2 to 1.2.3 in package.json. - Improved formatting and structure of the GitHub Actions workflow in cd.yml for better readability and maintainability. - Added conditional execution for the publish-npm job to ensure it only runs on pushes to the main branch.
|
nicolas-maalouf-cko
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable custom buttons and higher-level control without relying on SubmitButton; aligns with web parity and community feedback.
Changes: